Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-438 - Update Crowdin workflow #12038

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR updates the Crowdin workflow to use a temporary token. This will allow the PR to trigger the test workflow.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia requested a review from a team November 18, 2024 16:06
@vgrassia vgrassia self-assigned this Nov 18, 2024
@vgrassia vgrassia enabled auto-merge (squash) November 18, 2024 16:11
@vgrassia vgrassia merged commit 4d9dc9a into main Nov 18, 2024
20 of 21 checks passed
@vgrassia vgrassia deleted the bre-438_update-crowdin-workflow branch November 18, 2024 16:16
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.48%. Comparing base (c51b923) to head (6351c83).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12038   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files        2846     2846           
  Lines       89186    89186           
  Branches    17000    17000           
=======================================
  Hits        29864    29864           
  Misses      56969    56969           
  Partials     2353     2353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc81e6c33-9929-400c-a186-a9b14ba1f196

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 47 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants